Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabled prop for KeyboardStickyView #717

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 2, 2024

📜 Description

Added enabled property for KeyboardStickyView component. Also added this property to KeyboardToolbar.

💡 Motivation and Context

On top of what I remember this is iOS itself moves KeyboardToolbar (i. e. it's not interactive keyboard dismissal). So to fix the problem I decided to add enabled property. Using this property you can assure that views on previous screens are not animating/don't require additional style/layout computation.

A similar approach was used by KeyboardAvoidingView/KeyboardAwareScrollView components.

Even though if we fixed the problem of keeping KeyboardToolbar toughly bind to keyboard frame - on interactive gesture we would still see a KeyboardToolbar without a keyboard. So enabled property is the way to go at the moment.

Closes #716

📢 Changelog

JS

  • added enabled property for KeyboardStickyView;
  • added enabled property for KeyboardToolbar;

Docs

  • update documentation to reflect new property;

🤔 How Has This Been Tested?

Tested on CI and by external testers.

📸 Screenshots (if appropriate):

after.mov

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation enhancement New feature or request 📚 components Anything related to the exported components of this library labels Dec 2, 2024
@kirillzyusko kirillzyusko self-assigned this Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

📊 Package size report

Current size Target Size Difference
162236 bytes 162046 bytes 190 bytes 📈

Copy link

argos-ci bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 31, 2024, 11:12 PM

@kirillzyusko kirillzyusko added KeyboardStickyView 🩹 Anything related to KeyboardStickyView component KeyboardToolbar Anything related to KeyboardToolbar component labels Dec 2, 2024
@kirillzyusko kirillzyusko marked this pull request as ready for review December 3, 2024 11:14
@kirillzyusko kirillzyusko merged commit 08f9861 into main Dec 3, 2024
16 of 17 checks passed
@kirillzyusko kirillzyusko deleted the feat/keyboard-sticky-view-enabled-property branch December 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 components Anything related to the exported components of this library documentation Improvements or additions to documentation enhancement New feature or request KeyboardStickyView 🩹 Anything related to KeyboardStickyView component KeyboardToolbar Anything related to KeyboardToolbar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During back navigation in Stack Navigator, KeyboardToolba from the parent screen is also animating
1 participant