Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge offset properties for KeyboardToolbar #702

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 19, 2024

📜 Description

Added an ability to customize offset for KeyboardToolbar.

💡 Motivation and Context

If you use KeyboardToolbar with bottom-tabs (or in general if the bottom of the screen is not touching the bottom of window) then KeyboardToolbar will not be sticky to the keyboard.

To fix that we have to position toolbar in the end of the window. Since KeyboardToolbar is based on KeyboardStickyView (and KeyboardStickyView already has offset property) I decided to merge these propeprties.

Now KeyboardToolbar accepts offset property and merges it with default value (for closed state).

Closes #622

📢 Changelog

Docs

  • mention that KeyboardToolbar inherits properties from KeyboardStickyView.

JS

  • merge offset property with default value and pass it to keyboardStickyView;

🤔 How Has This Been Tested?

Tested manually in reproduction example.

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation enhancement New feature or request 🚨 requires API changes 🚨 Changes that requires changes in library API KeyboardToolbar Anything related to KeyboardToolbar component labels Nov 19, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-21 16:44 UTC

Copy link
Contributor

📊 Package size report

Current size Target Size Difference
161655 bytes 161399 bytes 256 bytes 📈

Copy link

argos-ci bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 19, 2024, 10:56 PM

@kirillzyusko kirillzyusko marked this pull request as ready for review November 20, 2024 14:45
@kirillzyusko kirillzyusko merged commit a300735 into main Nov 21, 2024
17 checks passed
@kirillzyusko kirillzyusko deleted the feat/toolbar-merge-offset-properties branch November 21, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request KeyboardToolbar Anything related to KeyboardToolbar component 🚨 requires API changes 🚨 Changes that requires changes in library API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank space beneath KeyboardToolbar after switching from emoji to text keyboard
1 participant