feat: merge offset
properties for KeyboardToolbar
#702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added an ability to customize
offset
forKeyboardToolbar
.💡 Motivation and Context
If you use
KeyboardToolbar
withbottom-tabs
(or in general if the bottom of the screen is not touching the bottom of window) thenKeyboardToolbar
will not be sticky to the keyboard.To fix that we have to position toolbar in the end of the window. Since
KeyboardToolbar
is based onKeyboardStickyView
(andKeyboardStickyView
already hasoffset
property) I decided to merge these propeprties.Now
KeyboardToolbar
acceptsoffset
property and merges it with default value (for closed state).Closes #622
📢 Changelog
Docs
KeyboardToolbar
inherits properties fromKeyboardStickyView
.JS
offset
property with default value and pass it tokeyboardStickyView
;🤔 How Has This Been Tested?
Tested manually in reproduction example.
📸 Screenshots (if appropriate):
📝 Checklist