-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stable iOS e2e tests #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
🍎 iOS
iOS specific
CI
CI (github actions)
e2e
Anything about E2E tests
labels
Mar 19, 2024
📊 Package size report
|
Looks like:
I opened an issue in detox - wix/Detox#4415 |
kirillzyusko
force-pushed
the
fix/stable-ios-e2e
branch
from
March 26, 2024 22:53
b575370
to
d4a1603
Compare
kirillzyusko
force-pushed
the
fix/stable-ios-e2e
branch
2 times, most recently
from
March 27, 2024 17:07
758ebe0
to
7eb6754
Compare
…g infinite loop) -> try back 14 again
kirillzyusko
force-pushed
the
fix/stable-ios-e2e
branch
from
March 30, 2024 22:38
05010ab
to
7bbe287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
CI (github actions)
deps update
Upgrade dependencies of the project
e2e
Anything about E2E tests
🍎 iOS
iOS specific
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Make iOS tests on CI stable again.
💡 Motivation and Context
Looks like after updating some of runners to XCode 15.3 booting up a simulator takes long time (actually it boots pretty fast, but after that CPU usage is close to 100% for quite big period of time). As a result tests are failing because of timeout.
I've tried many things - switching to other XCode versions, increasing timeout, changing the order of tests, changing runners, pre-booting simultator etc. and still tests very flaky in some cases.
However what I discovered is that after ~20mins and after several failures tests start to work okay. So I decided to add
--retry 2
flag to overcome the problem of flaky simulator - it makes CI green again. But if a regression really introduced - it'll fail anyway just with linger time of execution 🙂📢 Changelog
E2E
patch-package
;detox
;jest-setup.ts
file;AwareScrollView
test;CI
timeout
(60 -> 90);🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist