Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore duplicated events #298

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Dec 15, 2023

📜 Description

💡 Motivation and Context

Closes #286

📢 Changelog

JS

  • call scrollTo in onInteractive handler (to keep scroll position unchanged);

Android

  • compare current event with latest dispatched event;
  • added KeyboardTransitionEventData class;
  • added emitEvent as extension to ThemedReactContext;

🤔 How Has This Been Tested?

📸 Screenshots (if appropriate):

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added 🐛 bug Something isn't working 🤖 android Android specific 🚀 optimization You optimize something and it becomes working faster labels Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

📊 Package size report

Current size Target Size Difference
99851 bytes 99783 bytes 68 bytes 📈

@kirillzyusko kirillzyusko added the example Anything related to example project label Dec 15, 2023
@kirillzyusko kirillzyusko self-assigned this Dec 17, 2023
@kirillzyusko kirillzyusko force-pushed the fix/ignore-duplicated-events branch from 7481023 to 0619e91 Compare December 19, 2023 07:21
@kirillzyusko kirillzyusko force-pushed the fix/ignore-duplicated-events branch from 0619e91 to 96b041a Compare December 24, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🐛 bug Something isn't working example Anything related to example project 🚀 optimization You optimize something and it becomes working faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive Keyboard - fast swipe can cause UI elements be under keyboard using linear interpolator
1 participant