-
-
Notifications
You must be signed in to change notification settings - Fork 85
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove wrapper view from
KeyboardAwareScrollView
(#321)
## 📜 Description Removed view wrapper. Attached that view as last child + kept padding for this view. ## 💡 Motivation and Context The approach with additional view was added in #257 I don't remember exact reason, but for me it seems like it was added, because TExtInputs were not able to grow. However such approach is causing additional issues: - breaks styling in some cases - stickyHeaderIndices={[0]} produces a crash (because RN will try to attach `Animated`-based style to REA view) So in this PR I'm removing this view wrapper and apply additional padding in mostly the same way as it was before #257 (additional child-view in the end of ScrollView, but instead of `height` I'm animating `paddingBottom`). I've tested and it still works (i. e. inputs are growing). E2E tests also passing (so there seems to be 1px difference, which can be neglected, but i had to update assets to assure E2E tests consistency). > [!IMPORTANT] > This fix will introduce software-mansion/react-native-reanimated#5567. I've added that issue as "known issue" in docs page. I think it's better to have properly working paper architecture and Fabric can be fixed later (because it's still in early adoption and is not widely used). Closes #325 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### E2E - added `detox-clean` command (useful when you updated XCode version and haven't run detox tests yet) ### JS - removed wrapper and moved view as last child ## 🤔 How Has This Been Tested? Tested on: - e2e (Android, iOS - paper) - Pixel 7 Pro (Android 14, paper) ## 📸 Screenshots (if appropriate): There is no visual difference 🙂 ## 📝 Checklist - [x] CI successfully passed
- Loading branch information
1 parent
6f055c9
commit ec912c0
Showing
14 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+29 Bytes
(100%)
e2e/kit/assets/android/e2e_emulator/AwareScrollViewFirstInputFocused.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
e2e/kit/assets/android/e2e_emulator/AwareScrollViewFirstInputGrown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
e2e/kit/assets/android/e2e_emulator/AwareScrollViewInputChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
e2e/kit/assets/android/e2e_emulator/AwareScrollViewKeyboardClosed.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
e2e/kit/assets/android/e2e_emulator/AwareScrollViewTextChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
e2e/kit/assets/ios/iPhone 13 Pro/AwareScrollViewFirstInputFocused.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+258 Bytes
(100%)
e2e/kit/assets/ios/iPhone 13 Pro/AwareScrollViewFirstInputGrown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+61 Bytes
(100%)
e2e/kit/assets/ios/iPhone 13 Pro/AwareScrollViewInputChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+210 Bytes
(100%)
e2e/kit/assets/ios/iPhone 13 Pro/AwareScrollViewKeyboardClosed.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+232 Bytes
(100%)
e2e/kit/assets/ios/iPhone 13 Pro/AwareScrollViewTextChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters