Skip to content

Commit

Permalink
fix: web compatibility (#666)
Browse files Browse the repository at this point in the history
## 📜 Description

Bump `react-native-is-edge-to-edge` as it breaks web (webpack)
compatibility.

## 💡 Motivation and Context

There was a problem because `web` was resolving `index.mjs`, which had a
reference ti TurboModule and crashed the app:


![image](https://github.com/user-attachments/assets/7ce5c242-fecf-4254-8506-0ebf188b35d8)

It was fixed in `1.1.6` - all extensions were removed and files were
named correspondingly. So now all files can be properly resolved 😊

## 📢 Changelog

<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->

### JS

- bump `react-native-is-edge-to-edge` to `1.1.6`;

## 🤔 How Has This Been Tested?

Tested manually on webpack app.

## 📸 Screenshots (if appropriate):

<img width="2141" alt="image"
src="https://github.com/user-attachments/assets/0a2f12ef-eb06-4b63-8d4b-53826c677585">

## 📝 Checklist

- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed
  • Loading branch information
kirillzyusko authored Oct 29, 2024
1 parent e31a62a commit 22019a2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions FabricExample/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4637,10 +4637,10 @@ [email protected]:
invariant "^2.2.4"
prop-types "^15.7.2"

react-native-is-edge-to-edge@^1.1.5:
version "1.1.5"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.5.tgz#9dff7a1fad17ceb39ff48192c9ddaff5c72a637a"
integrity sha512-zt/0wLKBYTdoQdaZEvN9Ghi8Kz3Fo3LaWMzWZyJl7aLhvCNPebyi0DW449+PzC5xpIQdfcmumwkaB9VpymvViQ==
react-native-is-edge-to-edge@^1.1.6:
version "1.1.6"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.6.tgz#69ec13f70d76e9245e275eed4140d0873a78f902"
integrity sha512-1pHnFTlBahins6UAajXUqeCOHew9l9C2C8tErnpGC3IyLJzvxD+TpYAixnCbrVS52f7+NvMttbiSI290XfwN0w==

"react-native-keyboard-controller@link:..":
version "0.0.0"
Expand Down
8 changes: 4 additions & 4 deletions example/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4747,10 +4747,10 @@ [email protected]:
resolved "https://registry.yarnpkg.com/react-native-haptic-feedback/-/react-native-haptic-feedback-2.3.1.tgz#2ef4ac7d4f63ac06bd64b659f509362f127b16e5"
integrity sha512-dPfjV4iVHfhVyfG+nRd88ygjahbdup7KFZDM5L2aNIAzqbNtKxHZn5O1pHegwSj1t15VJliu0GyTX7XpBDeXUw==

react-native-is-edge-to-edge@^1.1.5:
version "1.1.5"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.5.tgz#9dff7a1fad17ceb39ff48192c9ddaff5c72a637a"
integrity sha512-zt/0wLKBYTdoQdaZEvN9Ghi8Kz3Fo3LaWMzWZyJl7aLhvCNPebyi0DW449+PzC5xpIQdfcmumwkaB9VpymvViQ==
react-native-is-edge-to-edge@^1.1.6:
version "1.1.6"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.6.tgz#69ec13f70d76e9245e275eed4140d0873a78f902"
integrity sha512-1pHnFTlBahins6UAajXUqeCOHew9l9C2C8tErnpGC3IyLJzvxD+TpYAixnCbrVS52f7+NvMttbiSI290XfwN0w==

"react-native-keyboard-controller@link:..":
version "0.0.0"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"registry": "https://registry.npmjs.org/"
},
"dependencies": {
"react-native-is-edge-to-edge": "^1.1.5"
"react-native-is-edge-to-edge": "^1.1.6"
},
"devDependencies": {
"@commitlint/config-conventional": "^11.0.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7685,10 +7685,10 @@ react-native-builder-bob@^0.18.0:
optionalDependencies:
jetifier "^2.0.0"

react-native-is-edge-to-edge@^1.1.5:
version "1.1.5"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.5.tgz#9dff7a1fad17ceb39ff48192c9ddaff5c72a637a"
integrity sha512-zt/0wLKBYTdoQdaZEvN9Ghi8Kz3Fo3LaWMzWZyJl7aLhvCNPebyi0DW449+PzC5xpIQdfcmumwkaB9VpymvViQ==
react-native-is-edge-to-edge@^1.1.6:
version "1.1.6"
resolved "https://registry.yarnpkg.com/react-native-is-edge-to-edge/-/react-native-is-edge-to-edge-1.1.6.tgz#69ec13f70d76e9245e275eed4140d0873a78f902"
integrity sha512-1pHnFTlBahins6UAajXUqeCOHew9l9C2C8tErnpGC3IyLJzvxD+TpYAixnCbrVS52f7+NvMttbiSI290XfwN0w==

[email protected]:
version "3.16.1"
Expand Down

0 comments on commit 22019a2

Please sign in to comment.