Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input validation in Timer #289

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix input validation in Timer #289

merged 2 commits into from
Nov 5, 2020

Conversation

cydanil
Copy link
Collaborator

@cydanil cydanil commented Nov 5, 2020

Description

closes #285, where the timer was reported to add zeroes and not validating the input correctly.

Values can now be at most 59 (hours, minutes, seconds).

How Has This Been Tested?

Screenshots (if appropriate):

timer

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cydanil cydanil merged commit 76e7aab into kirienko:master Nov 5, 2020
@cydanil cydanil deleted the fix/285 branch November 5, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra zeros are added when entering or deleting numbers in the timer
1 participant