Skip to content

Commit

Permalink
ofed_scripts/utils/mlnx_tune: Only disable qdisc tx for zero loss pro…
Browse files Browse the repository at this point in the history
…files

disable_qdisc_tx() is called for every profile. This causes a bug when
trying to set qdisc length afterwards (for zero loss profiles).
Fixed by only calling disable_qdisc_tx() for non zero loss profiles.

Signed-off-by: Bar Tuaf <[email protected]>
  • Loading branch information
Bar Tuaf authored and vladsokolovsky committed Jul 31, 2019
1 parent 63ce184 commit ba9f1df
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ofed_scripts/utils/mlnx_tune
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ from threading import Timer

VERSION_MAJOR = "4"
VERSION_MINOR = "6"
VERSION_BUILD = "4"
VERSION_BUILD = "5"

INDENT = 1
NA = "N/A"
Expand Down Expand Up @@ -3331,8 +3331,8 @@ def set_ip_forwarding_profile_single_stream(node_info, force_single = False, zer
for interface in device.interfaces:
if interface.status == InterfaceInfo.UP and interface.link_type == 'eth':
number_of_active_ethernet_interfaces += 1

interface.disable_qdisc_tx(node_info)
if not zero_loss:
interface.disable_qdisc_tx(node_info)
if device.type in Devices.MLX4_CONSUMERS:
set_xor_hash_rc = interface.apply_network_parameter_value('set-priv-flags', 'on', 'mlx4_rss_xor_hash_function')
if not set_xor_hash_rc:
Expand Down

0 comments on commit ba9f1df

Please sign in to comment.