Allow Options struct in to_string!/2 too and document it
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2021
kipcole9
added a commit
that referenced
this pull request
Jun 17, 2021
|
Thanks for the PR, much appreciated and gratefully accepted. I have published ex_money 5.5.4 with the following changelog: Bug Fixes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs that aim to improve performance by allowing both
%Cldr.Number.Format.Options{}structs to be passed as options in place of keyword lists, and to add support for%Cldr.Currency{}structs as alternative for currency codes.elixir-cldr/cldr_currencies#4
elixir-cldr/cldr_numbers#18
#127 (this PR)
Support for precompiled option structs was added before, but not to the
to_string!/2function, and this PR aims to add this in both documentation and in typespecs.