Support for Json (de)serialization #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code still needs a lot of work. It has no support yet for: - additional data - enums - collections - events It does run the first unit test however so the foundation seems to be good.
Due to implemnation of getChildNode, getting an object based on a discriminator works. Enums with a text value are supported (but not generically) Durations are supported.
Additional data is supported plus duration, date and time. (de)Serilization is by no means complete but good enough to start generating code. We will generate code for a simple client that gets version informationof an app.
As it looks like the lower case version is used everywhere including in other languages than Dart.
Configuration generics
Previously we had to manually copy the version.dart file in our .pub-cache folder.
@ricardo. I tried to not ignore the verion.dart file in .gitignore But it ignored it anyway. I know this is not a good solution that I will have to fix later.
Code seems to work with correct version.dart file.
Solved compilation error. Oddly enough the code seemed to work with this error.
…n subclasses of ApiException get lost
Switched from StringBuffer to using Uint8Buffer as it supports adding (binary) data.
In the process I had to make the return value of getValue(), nullable.
I know that the version.dart file is generated and not committed, but if I want to hand a generated SDK to a client they do not have the generated file and run into a problem. I will have to discuss this with Ricardo.
I know that the version.dart file is generated and not committed, but if I want to hand a generated SDK to a client they do not have the generated file and run into a problem. I will have to discuss this with Ricardo.
ricardoboss
reviewed
Oct 25, 2024
packages/kiota_serialization_form/lib/src/form_serialization_writer.dart
Outdated
Show resolved
Hide resolved
packages/kiota_serialization_json/lib/src/json_serialization_writer.dart
Outdated
Show resolved
Hide resolved
ricardoboss
reviewed
Nov 10, 2024
packages/kiota_serialization_form/lib/src/form_serialization_writer.dart
Show resolved
Hide resolved
|
@joanne-ter-maat @Kees-Schotanus can one of you add yourselves to the |
… in writeAdditionalData
Instead of checking just the header, the complete serialized object is now verified.
ricardoboss
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.