usage of correct type (int) for rate variable #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RamaMalladiAWS <[email protected]>
Signed-off-by: RamaMalladiAWS <[email protected]>
RamaMalladiAWS
changed the title
|
any update on this? |
|
Missing in the description seems to be that, the signedness of char isn't specified in the c standard, and arm64/aarch64/arm all assume unsigned. This means that getopt_long() doesn't work right and since getopt_long() returns an int this fixes argument parsing on arm-based systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate variable needs to be an int.
The rate variable was declared as "char". But it needs to be an int. This PR changes it.
Standard build and run.
Builds and works out-of-the-box.