Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

coredns use version tag #1203

Merged
merged 3 commits into from
Nov 23, 2020
Merged

coredns use version tag #1203

merged 3 commits into from
Nov 23, 2020

Conversation

knrt10
Copy link
Member

@knrt10 knrt10 commented Nov 23, 2020

See commit message for more information

closes: #374
Signed-off-by: knrt10 [email protected]

@knrt10 knrt10 requested review from invidian and surajssd November 23, 2020 05:01
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, though rebase is needed.

Let docker daemon figure out the architecture and use version 1.8.0

closes: #374
Signed-off-by: knrt10 <[email protected]>
We were already using default image as tagged image. No need to specify
the architecture, so removed it.

Signed-off-by: knrt10 <[email protected]>
@knrt10 knrt10 force-pushed the knrt10/coredns-use-version-tag branch from 05bba2c to e8b5634 Compare November 23, 2020 09:53
@knrt10 knrt10 requested a review from invidian November 23, 2020 09:53
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if ARM build is still passing 😄)

@invidian invidian merged commit 004a8fc into master Nov 23, 2020
@invidian invidian deleted the knrt10/coredns-use-version-tag branch November 23, 2020 11:49
@invidian invidian mentioned this pull request Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreDNS is not version tagged
3 participants