Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Add reboot test for FLUO #1142

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Add reboot test for FLUO #1142

merged 2 commits into from
Nov 4, 2020

Conversation

surajssd
Copy link
Member

No description provided.

@surajssd surajssd force-pushed the surajssd/add-fluo-tests branch from d7a9916 to cc7c565 Compare October 29, 2020 13:37
@surajssd surajssd force-pushed the surajssd/add-fluo-tests branch 3 times, most recently from 6b9a098 to 31d9f2a Compare October 30, 2020 11:42
@surajssd
Copy link
Member Author

I am not sure what's going wrong in the 'Packet FLUO' pipeline it always errors out on

=== CONT  TestReboot
    util.go:81: using KUBECONFIG=/root/lokoctl-assets/cluster-assets/auth/kubeconfig
    fluo_reboot_test.go:52: Chosen node to reboot: ci1604058269-re-general-worker-0
    fluo_reboot_test.go:61: Annotation "flatcar-linux-update.v1.flatcar-linux.net/reboot-paused" not found on the node.
--- FAIL: TestReboot (0.03s)

@surajssd
Copy link
Member Author

Oh CI code only applies the annotations to packet and to packet_fluo 🤦

invidian
invidian reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what this is testing exactly. There seems to be nothing specific to Lokomotive in those tests, perhaps they should be moved to FLUO repository?

Also, how possible reboots play with #1084? Won't reboot interrupt the other test and make it fail?

test/components/flatcar-linux-update-operator/fluo_reboot_test.go Outdated Show resolved Hide resolved
@surajssd
Copy link
Member Author

I don't fully understand what this is testing exactly.

This tests FLUO on lokomotive and if it can safely reboot machine. This is most basic test for stateless nodes. This pipeline also runs rook-ceph tests and hence we can extend the testing on FLUO further to test upgrading nodes with rook-ceph running.

There seems to be nothing specific to Lokomotive in those tests, perhaps they should be moved to FLUO repository?

The argument is true for so many other component e2e tests like prometheus-operator, metallb, contour, etc.

Also, how possible reboots play with #1084? Won't reboot interrupt the other test and make it fail?

This is marked as disruptive e2e test.

@surajssd surajssd force-pushed the surajssd/add-fluo-tests branch 2 times, most recently from 1cefc27 to 462b7fa Compare October 30, 2020 13:37
@surajssd surajssd force-pushed the surajssd/add-fluo-tests branch from 462b7fa to 510664c Compare October 30, 2020 13:55
@surajssd surajssd requested review from invidian and knrt10 October 30, 2020 15:35
@surajssd
ci: Install FLUO
9cca24b 
Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
FLUO: Add reboot test
8eab54a 
This commit adds a reboot test for FLUO, the test verifies if the FLUO
can reboot a node running stateless applications.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd surajssd force-pushed the surajssd/add-fluo-tests branch from 510664c to 8eab54a Compare November 4, 2020 09:30
invidian
invidian approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invidian invidian merged commit 10e30c0 into master Nov 4, 2020
@invidian invidian deleted the surajssd/add-fluo-tests branch November 4, 2020 12:54
@iaguis iaguis mentioned this pull request Nov 4, 2020
Closed
@invidian invidian mentioned this pull request Dec 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@knrt10 knrt10 knrt10 approved these changes

@invidian invidian invidian approved these changes

@iaguis iaguis iaguis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surajssd @iaguis @invidian @knrt10