This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
2 times, most recently
from
October 28, 2020 07:25
8961b80
to
1a94f3a
Compare
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 9, 2020 13:15
1a94f3a
to
7564dde
Compare
TODO:
|
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 9, 2020 13:52
7564dde
to
bbee9ba
Compare
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 10, 2020 14:19
bbee9ba
to
86a2cf3
Compare
|
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 11, 2020 10:19
86a2cf3
to
cae75e6
Compare
invidian
suggested changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, otherwise looks good to me.
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 20, 2020 12:07
cae75e6
to
ab04882
Compare
invidian
suggested changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also mention in the commit message or code comment (or both) that date format change is a workaround until we update linkerd dependency.
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 23, 2020 08:57
ab04882
to
1ae435a
Compare
invidian
previously approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update to app version: `2.9.0`. Release Notes: https://github.com/linkerd/linkerd2/releases/tag/stable-2.9.0 Signed-off-by: Suraj Deshmukh <[email protected]>
This commit changes the expiry date format from the golang's default to `RFC3339`. This change is introduced because the proxy injector errors with following errors: ``` failed to inject sidecar. Reason: failed to unmarshal JSON from: /var/run/linkerd/config/values: error unmarshaling JSON: while decoding JSON: parsing time "2021-11-09 07:43:12 +0000 UTC" as "2006-01-02T15:04:05Z07:00": cannot parse " 07:43:12 +0000 UTC" as "T" ``` This problem should be fixed once we update the linkerd libs, and it would be safe to revert this commit. Signed-off-by: Suraj Deshmukh <[email protected]>
This commit updates the values file for HA setup to match upstream config. Signed-off-by: Suraj Deshmukh <[email protected]>
- Add new variable `prometheus_url` where user can provide the link to the external prometheus from where linkerd can scrape the metrics. Signed-off-by: Suraj Deshmukh <[email protected]>
This commit includes relabel config from the prometheus config mentioned in: https://linkerd.io/2/tasks/external-prometheus/. Signed-off-by: Suraj Deshmukh <[email protected]>
Signed-off-by: Suraj Deshmukh <[email protected]>
surajssd
force-pushed
the
surajssd/upgrade-linkerd2
branch
from
November 23, 2020 15:11
1ae435a
to
766eb94
Compare
invidian
approved these changes
Nov 23, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896