Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(data-loader): move jest.setTimeout to top of the file #1024

Merged
merged 2 commits into from
Jul 27, 2021
Merged

test(data-loader): move jest.setTimeout to top of the file #1024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b52d4ae
test: move `jest.setTimeout` to top of the file
zaki-yama Jul 21, 2021
8c4e5cf
chore: extend timeout to 30 sec
zaki-yama Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/data-loader/src/__tests__/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ const mainFilePath = path.resolve(
packageJson.bin["kintone-data-loader"]
);

beforeEach(() => {
jest.setTimeout(10000);
});
jest.setTimeout(30000);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to extend the timeout, and have no specific reason why I chose 30000.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: https://jestjs.io/docs/jest-object#jestsettimeouttimeout

This only affects the test file from which this function is called.


const checkRejectArg = ({
arg,
Expand Down