Fix #390 edge case when typed properties are referenced in arrays

kint-php · Jun 26, 2023 · a700653 · a700653
1 parent efdcb51
commit a700653
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/build/kint.phar b/build/kint.phar
diff --git a/src/Parser/Parser.php b/src/Parser/Parser.php
@@ -374,7 +374,11 @@ private function parseArray(array &$var, Value $o): Value
             }
 
             $stash = $val;
-            $copy[$i] = $refmarker;
+            try {
+                $copy[$i] = $refmarker;
+            } catch (TypeError $e) {
+                $child->reference = true;
+            }
             if ($val === $refmarker) {
                 $child->reference = true;
                 $val = $stash;

diff --git a/tests/Parser/ParserTest.php b/tests/Parser/ParserTest.php
@@ -583,6 +583,19 @@ public function testParseReferences()
             foreach ($o->value->contents as $val) {
                 $this->assertSame('b' === $val->name, $val->reference);
             }
+
+            $v = new Php74TestClass();
+            $v->b = 'test';
+            $a = [
+                'testval' => $v->b,
+                'testref' => &$v->b,
+            ];
+
+            $o = $p->parse($a, clone $b);
+
+            foreach ($o->value->contents as $val) {
+                $this->assertSame('testref' === $val->name, $val->reference);
+            }
         }
     }