Added FileAPI object to the signature #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an FYI update on this. I haven't forgotten about this PR which is very much appreciated! I'll try and get this in over the weekend. |
|
@kinstephen How's your weekend doing? 😜 |
|
Oh my!!! It’s been a very very long weekend! lol Life can sure keep you distracted. This repo gets so little attention I tend to forget it even exists lol! I’m actually on holiday now and can’t easily check the source. I’ll set myself a reminder to check on this Sunday/Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a single file, it's easy to know which object to track progress on.
In the case of multiple file upload all hooked to the same events, there's no easy way to know which object I'm uploading.
The FileAPI object has an
$$hashKeyproperties that uniquely identify the object that events are being reported on.I added that object to the event.
Minor changes: added a missing semicolon. removed an unnecessary semicolon.