Test for device class by type vs isinstance #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derjoerg
previously approved these changes
Nov 13, 2024
|
Added a fix for pnuckowski/aioresponses#262 |
bdraco
reviewed
Nov 15, 2024
Comment on lines
+1
to
+4
| # There's an issue with aioresponses and the latest version of aiohttp | ||
| # Pin an earlier version for development until PR is merged and released. | ||
| # https://github.com/pnuckowski/aioresponses/pull/262 | ||
| aiohttp<3.11.0 |
There was a problem hiding this comment.
You can likely drop the pin now that 3.11.1 is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing for device class using isinstance it also pulls in sub-classes.
We want to get the class by the exact type, we don’t want to include type inheritence.