Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clippy): fix clippy issues for rustc 1.66.0 #269

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

dan-da
Copy link

@dan-da dan-da commented Dec 20, 2022

The latest rustc 1.66.0 toolchain issues a bunch of clippy warnings/errors, which CI is unhappy with.

This fixes that so clippy is happy, eg:

$ cd Kindelia

$ cargo --version
cargo 1.66.0 (d65d197ad 2022-11-15)

$ cargo clippy --all-targets --all-features
    Finished dev [unoptimized + debuginfo] target(s) in 0.28s

edit: rustfmt (cargo fmt) should also be run over the entire repo and I'm happy to make a PR for that, but there are a bunch of PRs pending, and I think its best to wait until most of those have been merged to avoid some unnecessary conflicts.

@racs4 racs4 self-requested a review December 21, 2022 18:12
@racs4 racs4 merged commit 6959759 into kindelia:dev Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants