PR#7 Fix - Added Support for Auth URL Params + Test Fixes #8
Conversation
Contributions from Serhii Holovashchuk kinde-oss#7 Fixed config.yaml Fixed failing tests on `flutter test` - Added test values.
Used the similar pattern for the test values.
WalkthroughThis update enhances the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
malik19995
changed the title
malik19995
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (4)
my_custom_templates/lib/src/auth_url_params.dart (2)
2-3: Use consistent naming conventions for private fields.Consider using a consistent naming convention for private fields, such as prefixing with an underscore.
- static const _lang = 'lang'; - static const _connectionId = 'connection_id'; + static const String _lang = 'lang'; + static const String _connectionId = 'connection_id';
5-9: Add documentation for class fields.While there are comments, consider using Dart's documentation comments (
///) for consistency and better integration with documentation tools./// Language to display for login page String? lang; /// Connection id string corresponding to social sign in String? connectionId;my_custom_templates/lib/src/kinde_flutter_sdk.dart (2)
195-212: Update test cases to match the newregisterfunction signature.The
registerfunction has been updated to includeloginHintandauthUrlParamsparameters. However, the test cases inmy_custom_templates/test/kinde_flutter_sdk_test.dartdo not include these new parameters. Please update the test cases to match the new function signature and ensure the new parameters are tested properly.
my_custom_templates/test/kinde_flutter_sdk_test.dart:
- Update the
registerfunction calls to includeloginHintandauthUrlParams.Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
registermatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `register` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type dart -A 5 $'register'Length of output: 1689
161-172: Function calls tologindo not match the new signature.The following instances of
logincalls do not include the new parametersloginHintandauthUrlParams:
my_custom_templates/test/kinde_flutter_sdk_test.dart: await KindeFlutterSDK.instance.login();Please update these calls to match the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
loginmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `login` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type dart -A 5 $'login'Length of output: 12910
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
config.yamlis excluded by!**/*.yamlmy_custom_templates/openapitools.jsonis excluded by!**/*.json
Files selected for processing (6)
- .gitignore (1 hunks)
- my_custom_templates/lib/kinde_sdk.dart (1 hunks)
- my_custom_templates/lib/src/auth_url_params.dart (1 hunks)
- my_custom_templates/lib/src/kinde_flutter_sdk.dart (6 hunks)
- my_custom_templates/test/organizations_api_test.dart (1 hunks)
- my_custom_templates/test/users_api_test.dart (1 hunks)
Files skipped from review due to trivial changes (2)
- .gitignore
- my_custom_templates/lib/kinde_sdk.dart
Additional comments not posted (6)
my_custom_templates/lib/src/auth_url_params.dart (1)
11-14: Constructor looks good.The constructor correctly initializes the fields.
my_custom_templates/test/users_api_test.dart (1)
64-65: Test updateUser looks good.The addition of the
idparameter ensures the test aligns with the updated method signature.my_custom_templates/test/organizations_api_test.dart (1)
34-36: Test createOrganization looks good.The addition of the
nameparameter ensures the test has a defined context and expected behavior.my_custom_templates/lib/src/kinde_flutter_sdk.dart (3)
Line range hint
177-191:
LGTM! The changes are approved.The code changes are straightforward and correctly integrated.
Line range hint
266-277:
LGTM! The changes are approved.The code changes are straightforward and correctly integrated.
Line range hint
292-303:
LGTM! The changes are approved.The code changes are straightforward and correctly integrated.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- my_custom_templates/lib/src/auth_url_params.dart (1 hunks)
Files skipped from review due to trivial changes (1)
- my_custom_templates/lib/src/auth_url_params.dart
|
Here's the documentation for Auth URL Params for the Flutter Integration docs at https://docs.kinde.com/developer-tools/sdks/native/flutter-sdk/ |
Contributions from Serhii Holovashchuk
#7
Explain your changes
Fixed config.yaml -- Added reference for auth_url_params.dart
Fixed failing tests on
flutter testin generated kinde-flutter-sdk:test_org_nameto test createOrganizationtest_user_idto test updateUserChecklist