Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added export module #538

Merged
merged 29 commits into from
Feb 5, 2019
Merged

added export module #538

merged 29 commits into from
Feb 5, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 1, 2019

Ignore the failing tests, I'll fix them later.

Do not use/test this branch in your existing installation, but only in a new dev environment - the database structure changed and that would be incompatible with your own installation.

You can also test this PR (while its open) at the following URL with the regular demo accounts:
https://demo-branch.kimai.org/

@infeeeee
Copy link
Contributor

infeeeee commented Feb 1, 2019

Very nice, thank you, I installed the export-module branch.

  • The text in the mark all dialog is this: export.mark_all
  • I see the summary in the pdf export, why it's only there? I think it should make sense in the print export as well
  • It feels strange that the export buttons are below the table if I select a lot of entries. Of course I can push the End button on the keyboard, but it's a little bit inconvenient.

But the module is very nice, thank you again

@kevinpapst
Copy link
Member Author

Thanks or your feedback @infeeeee !
I added the missing translation and the summary to the print view

@blochwitz
Copy link

Hi Kevin,

is the export module still a part of the timezone branch?

@kevinpapst
Copy link
Member Author

kevinpapst commented Feb 4, 2019

@blochwitz no and it has never been, each PR has its own branch. But maybe I don't understand your question?!

@kevinpapst kevinpapst merged commit 8168665 into master Feb 5, 2019
@kevinpapst kevinpapst deleted the export-module branch February 5, 2019 20:37
@lock
Copy link

lock bot commented Apr 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants