Enter confirms subtitle track selection #445
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It is no longer really useful since there is now a setting that controls offset for the webapp's video player
- Allow subtitles to take up more width on the screen. Especially helps with mobile UX.
- E.g. in the case of Amazon Prime when scrolling down the page and then opening a video.
- Support lazy-fetching of subtitle track URLs that are not provided on the initial manifest fetch
|
Hi @pooky-programs , sorry for taking a long time to look at this. I thought that your changes were still in-progress since the PR is in draft. |
killergerbah
requested changes
Jul 26, 2024
| @@ -186,6 +204,8 @@ export default function VideoDataSyncDialog({ | |||
| return newSelectedSubtitles; | |||
| }) | |||
| } | |||
| onFocus={() => setIsDropdownActive(true)} | |||
| onBlur={() => setIsDropdownActive(false)} | |||
There was a problem hiding this comment.
As you pointed out, with this implementation it still takes another click for the dialog to respond to the Enter key. I think for this change to be really useful the dialog should close on Enter as long as none of the drop-downs are open. This would reduce the total clicks required to select subtitles.
|
@killergerbah no problem, and yeah this is still WIP! I just haven't had the time to sit down and work on it again, sorry for not telling you sooner. I'll be attempting to fix it after July ends. |
* Readme: update dictionaries and regex sections * Note about one click mining * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
- So that popup dictionary UI is more likely to appear on top
* add default policy if one doesn't exist * revert speculative fix commit * add comment linking chrome tests
…e subtitle) (killergerbah#474) * VideoPlayer.tsx: Don't newline subtitles. (Let yomitan pick up the full sub) * Videoplayer.tsx: Also wrap text with <p> when dom caching is disabled * video-player.css: Fix excessive gap on bottom of subtitles (visible with pre-cache subtitle dom + multiple sub track) * undo inline: messed with splits on subs, whiteSpace made a huge box under the sub box (material ui css stuff) * videoplayer.tsx: lineheight: normal -> inherit, better spacing look * prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #378
VideoDataSyncDialog now listens for enter key press when subtitle drop downs aren't in focus.
Can be significantly improved if I can figure out how to shift focus from the side panel to the dialog when it opens on click.
Currently it only submits on enter when the dialog is focused after a click, which I understand is not ideal for what the original issue intended.