Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TeaCache Support and node #226

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added TeaCache Support and node #226

wants to merge 8 commits into from

Conversation

ctf05
Copy link

@ctf05 ctf05 commented Dec 27, 2024

It works. I did very little testing. You get a speed-up with a loss of quality but you can get a ~1.4x speedup with little loss.

@DiffuzionDreamer
Copy link

DiffuzionDreamer commented Dec 31, 2024

I'm getting an error when running it in conjunction with Enhance-A-Video:
Screenshot from 2024-12-31 18-10-22

But... I'm also able to run them together after running with just TeaCache and then again with both EAV and TC. Love the speed increase with TC but I wouldn't know where to begin to fix the bug.

@morganavr
Copy link

Sometimes after I reload workflow from .json I got this error.
I use TeaCache with Enhance-A-Video.
image

@DarioFT
Copy link

DarioFT commented Dec 31, 2024

@DiffuzionDreamer I've created a small PR that addresses this on @ctf05 's fork.

feat: add FETA initialization and configuration in HyVideoSampler
@ctf05
Copy link
Author

ctf05 commented Dec 31, 2024

@DiffuzionDreamer I've created a small PR that addresses this on @ctf05 's fork.

I just saw this. Thanks for the fix. It fixed some problems I had. I think TeaCache is bug free now. (known bugs)

@DiffuzionDreamer
Copy link

DiffuzionDreamer commented Dec 31, 2024

Tested the fix and and it is working on my system, and seems to resolve the issue reported by @morganavr as well which had occured for me when aiming for larger/longer outputs.

@morganavr
Copy link

TeaCache does not work with BlockSwap node - it throws an exception

RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants