Skip to content

Commit

Permalink
chore(build): remove tslint options
Browse files Browse the repository at this point in the history
We've removed tslint from build cycles a while ago, but these options remained.

Close angular#2616
  • Loading branch information
filipesilva authored and kieronqtran committed Oct 21, 2016
1 parent 91e6171 commit db131a9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 28 deletions.
23 changes: 0 additions & 23 deletions packages/angular-cli/models/webpack-build-development.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
const path = require('path');

import * as webpack from 'webpack';

declare module 'webpack' {
export interface LoaderOptionsPlugin {}
export interface LoaderOptionsPluginStatic {
new (optionsObject: any): LoaderOptionsPlugin;
}
interface Webpack {
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
}
};

export const getWebpackDevConfigPartial = function(projectRoot: string, appConfig: any) {
return {
devtool: 'cheap-module-source-map',
Expand All @@ -21,17 +9,6 @@ export const getWebpackDevConfigPartial = function(projectRoot: string, appConfi
sourceMapFilename: '[name].map',
chunkFilename: '[id].chunk.js'
},
plugins: [
new webpack.LoaderOptionsPlugin({
options: {
tslint: {
emitErrors: false,
failOnHint: false,
resourcePath: path.resolve(projectRoot, appConfig.root)
},
}
})
],
node: {
fs: 'empty',
global: true,
Expand Down
15 changes: 10 additions & 5 deletions packages/angular-cli/models/webpack-build-production.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ const WebpackMd5Hash = require('webpack-md5-hash');
const CompressionPlugin = require('compression-webpack-plugin');
import * as webpack from 'webpack';

declare module 'webpack' {
export interface LoaderOptionsPlugin {}
export interface LoaderOptionsPluginStatic {
new (optionsObject: any): LoaderOptionsPlugin;
}
interface Webpack {
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
}
}

export const getWebpackProdConfigPartial = function(projectRoot: string, appConfig: any) {
return {
devtool: 'source-map',
Expand All @@ -28,11 +38,6 @@ export const getWebpackProdConfigPartial = function(projectRoot: string, appConf
}),
new webpack.LoaderOptionsPlugin({
options: {
tslint: {
emitErrors: true,
failOnHint: true,
resourcePath: path.resolve(projectRoot, appConfig.root)
},
htmlLoader: {
minimize: true,
removeAttributeQuotes: false,
Expand Down

0 comments on commit db131a9

Please sign in to comment.