NO-ISSUE: Remove mkdir command from extended-services-image and fix R…

…EADMEs from dev-deployment images (apache#2205) Co-authored-by: Alex thiagolugli <[email protected]>
kiegroup · Mar 28, 2024 · b6a7d55 · b6a7d55
1 parent 17561a7
commit b6a7d55
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/packages/dev-deployment-base-image/README.md b/packages/dev-deployment-base-image/README.md
@@ -5,6 +5,9 @@ Docker image with Java and Maven, as well as the dev-deployment-upload-service b
 ## Build arguments
 
 - `BUILDER_IMAGE_ARG`: The base image used for building this image (defaults to `registry.access.redhat.com/ubi9/openjdk-17:1.18`).
+  - Tested with:
+    - registry.access.redhat.com/ubi9/openjdk-17:1.18
+    - icr.io/appcafe/ibm-semeru-runtimes:open-17-jdk-ubi-minimal
 
 ## Environment variables
 
@@ -20,3 +23,13 @@ Docker image with Java and Maven, as well as the dev-deployment-upload-service b
 ### Optional
 
 - `DEV_DEPLOYMENT__UPLOAD_SERVICE_ROOT_PATH`: If the Upload Service is not running in the root path of the URL, this variable should be specified.
+
+## Test locally
+
+Run the image with:
+
+- `docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=123 quay.io/kie-tools/dev-deployment-base-image:daily-dev 'dev-deployment-upload-service && ./mvnw quarkus:dev'`
+
+Then upload a zip file containing the resources (full Java project)
+
+- `curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=@<ABSOLUTE_PATH_TO_YOUR_FILE>" 'http://localhost:8080/upload?apiKey=123'`
diff --git a/packages/dev-deployment-kogito-quarkus-blank-app-image/README.md b/packages/dev-deployment-kogito-quarkus-blank-app-image/README.md
@@ -28,8 +28,8 @@ These files can decisions or processes, all of them will be used as resources fo
 
 Run the image with:
 
-- `docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=123 quay.io/kie-tools/dev-deployment-kogito-quarkus-blank-app-image:latest`
+- `docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=123 quay.io/kie-tools/dev-deployment-kogito-quarkus-blank-app-image:daily-dev`
 
 Then upload a zip file containing the resources (DMN, BPMN, etc)
 
-- `curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=@<ABSOLUTE_PATH_TO_YOUR_FILE>" http://localhost:8080/upload?apiKey=123`
+- `curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=@<ABSOLUTE_PATH_TO_YOUR_FILE>" 'http://localhost:8080/upload?apiKey=123'`
diff --git a/packages/kie-sandbox-extended-services-image/Containerfile b/packages/kie-sandbox-extended-services-image/Containerfile
@@ -26,8 +26,6 @@ ARG EXTENDED_SERVICES_DEFAULT_PORT
 ENV EXTENDED_SERVICES_HOST=$EXTENDED_SERVICES_DEFAULT_HOST
 ENV EXTENDED_SERVICES_PORT=$EXTENDED_SERVICES_DEFAULT_PORT
 
-RUN mkdir kie-sandbox
-
 COPY --chown=1000:0 dist-dev/kie_sandbox_extended_services /kie-sandbox/kie_sandbox_extended_services
 
 EXPOSE $EXTENDED_SERVICES_PORT