add sample to delete.py and meta.py #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
reviewed
Jun 10, 2024
kf_utils/dataservice/delete.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| "participants", | |||
| "family-relationships", | |||
| "families", | |||
| "sample", | |||
There was a problem hiding this comment.
This list is in a specific order for deletion to work w the fk references, so you'd have to move sample to be above participants and also change it to samples
There was a problem hiding this comment.
ok thank you i fixed that!
Co-authored-by: Natasha Singh <[email protected]>
…f-utils-python into add_sample_deletion
znatty22
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description here]
added to allow deletion of sample entities