Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐎 sets for faster searching #176

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

dmiller15
Copy link
Contributor

Description

Small optimization I made over the break. Look-ups in sets are much faster than lists.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added enhancement New feature or request bix-dev This issue or pull request is bix-dev work labels Jan 2, 2024
@dmiller15 dmiller15 self-assigned this Jan 2, 2024
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmiller15 dmiller15 merged commit 614dbfa into master Jan 18, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-optimize-table-builder branch January 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants