Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3346 duplicate freactal fences provider into redux #3358

Merged
merged 8 commits into from
Jul 14, 2021
Merged

#3346 duplicate freactal fences provider into redux #3358

merged 8 commits into from
Jul 14, 2021

Conversation

evans-g-crsj
Copy link
Contributor

No description provided.

celinepelletier
celinepelletier approved these changes Jul 12, 2021
View reviewed changes
src/store/fenceConnectionsTypes.ts Outdated Show resolved Hide resolved
@evans-g-crsj evans-g-crsj force-pushed the 3346-extract-fences-from-freactal branch from 5120d90 to 55dce61 Compare July 14, 2021 16:36
@evans-g-crsj evans-g-crsj marked this pull request as ready for review July 14, 2021 16:38
francisl
francisl reviewed Jul 14, 2021
View reviewed changes
Copy link

@francisl francisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comments

src/components/UserDashboard/index.js Outdated Show resolved Hide resolved
src/components/UserProfile/Integration.js Show resolved Hide resolved
francisl
francisl approved these changes Jul 14, 2021
View reviewed changes
Copy link

@francisl francisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@evans-g-crsj evans-g-crsj merged commit 3b6d8ec into kids-first:dev Jul 14, 2021
@evans-g-crsj evans-g-crsj deleted the 3346-extract-fences-from-freactal branch July 14, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinepelletier celinepelletier celinepelletier approved these changes

@adipaul1981 adipaul1981 adipaul1981 approved these changes

@francisl francisl francisl approved these changes

@jecos jecos Awaiting requested review from jecos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evans-g-crsj @francisl @adipaul1981 @celinepelletier