Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤡 Improve mocks #254

Merged
merged 5 commits into from
Apr 20, 2020
Merged

🤡 Improve mocks #254

merged 5 commits into from
Apr 20, 2020

Conversation

dankolbman
Copy link
Contributor

Fixes issues with the development environment starting in docker compose and makes fake data consistent with study creator.

@dankolbman dankolbman added devops Involves features of the deployment refactor Something needs to be done better feature New functionality labels Apr 20, 2020
@dankolbman dankolbman requested a review from XuTheBunny April 20, 2020 20:01
@dankolbman dankolbman self-assigned this Apr 20, 2020
Copy link
Contributor

@XuTheBunny XuTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #254 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         101      101           
  Lines        3473     3475    +2     
=======================================
+ Hits         2992     2994    +2     
  Misses        481      481           
Impacted Files Coverage Δ
coordinator/api/factories/release.py 90.47% <100.00%> (+1.00%) ⬆️
tests/graphql/releases/test_cancel_release.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47013d9...e1c7163. Read the comment docs.

@dankolbman dankolbman merged commit 8102d56 into master Apr 20, 2020
@dankolbman dankolbman deleted the improve-mocks branch April 20, 2020 20:31
dankolbman added a commit that referenced this pull request Sep 11, 2020
## Release 1.9.1

### Summary

- Emojis: 🔧 x3, 🐛 x1, 🏭 x1, 👷 x1, ⬆️ x1, 🤡 x1
- Categories: Other Changes x5, Fixes x1, Ops x2

### New features and changes

- [#268](#268) - 🔧 Added JenkinsfileWorker - [e8caed9](e8caed9) by [alubneuski](https://github.com/alubneuski)
- [#267](#267) - 🔧 Updated to standard deploy - [f690674](f690674) by [alubneuski](https://github.com/alubneuski)
- [#262](#262) - 🔧 Add SSL setting to RQ config - [bb956ca](bb956ca) by [dankolbman](https://github.com/dankolbman)
- [#259](#259) - 🐛 Fix release factory - [647fb5c](647fb5c) by [dankolbman](https://github.com/dankolbman)
- [#258](#258) - 🏭 Use more fake studies for releases - [9a36b54](9a36b54) by [dankolbman](https://github.com/dankolbman)
- [#257](#257) - 👷 Publish to dockerhub action - [437da28](437da28) by [dankolbman](https://github.com/dankolbman)
- [#255](#255) - ⬆️ Bump django from 2.1.11 to 2.2.13 - [ddf9e4b](ddf9e4b) by [dependabot[bot]](https://github.com/apps/dependabot)
- [#254](#254) - 🤡 Improve mocks - [8102d56](8102d56) by [dankolbman](https://github.com/dankolbman)
@dankolbman dankolbman mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Involves features of the deployment feature New functionality refactor Something needs to be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants