Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Refactor settings #143

Merged
merged 2 commits into from
Mar 12, 2019
Merged

🔧 Refactor settings #143

merged 2 commits into from
Mar 12, 2019

Conversation

dankolbman
Copy link
Contributor

Refactors settings into the coordinator/settings directory to be consistent across projects.
Also renames base.py to production.py and test.py to testing.py to stay consistent.
Allows the DJANGO_SETTINGS_MODULE to be passed in when running docker-compose.

@dankolbman dankolbman self-assigned this Mar 11, 2019
@dankolbman dankolbman requested a review from XuTheBunny March 11, 2019 23:57
XuTheBunny
XuTheBunny approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@XuTheBunny XuTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@dankolbman dankolbman merged commit 63355f9 into master Mar 12, 2019
@dankolbman dankolbman deleted the refactor-settings branch March 12, 2019 00:18
@dankolbman dankolbman mentioned this pull request Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuTheBunny XuTheBunny XuTheBunny approved these changes

Assignees

@dankolbman dankolbman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dankolbman @XuTheBunny