Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1712] No Reward Option Not Shown in Edit Reward Flow #2150

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Sep 6, 2024

📲 What

Bug found in QA

  • When pledging with a "no reward" selection this option wasn't being shown in the "Edit Reward" flow.
  • It also wasn't selectable/editable

🤔 Why

  • We should be showing the currently selected reward
  • The currently selected reward should be selectable so that backers can update their pledge/bonus amounts. Since those steppers were moved to the rewards screen we need to update this behavior.

🛠 How

Instead of only allowing rewards in the "Edit Rewards" flow to be editable if they have add ons we should update this condition so that it's true if it has add ons and/or the no shipping at checkout feature flag is on.

👀 See

Simulator Screen Recording - iPhone 15 Pro 17 5 - 2024-09-06 at 13 22 31

✅ Acceptance criteria

  • Backers can select their current pledged reward and adjust their bonus/pledge amounts
  • Backers can change rewards/add-ons etc. successfully
  • When the feature flag is off, "edit reward" and "manage pledge" flows work as normal

@scottkicks scottkicks self-assigned this Sep 6, 2024
@scottkicks scottkicks marked this pull request as ready for review September 6, 2024 20:55
Copy link
Contributor

@ifosli ifosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm surprised this automatically passes existing tests - it'd be nice to add a test to cover this case as part of this pr!

@scottkicks scottkicks merged commit 5c1e775 into main Sep 9, 2024
5 checks passed
@scottkicks scottkicks deleted the scott/redemption/edit-reward-fixes branch September 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants