[MBL-1690] Crash When Selecting 'Edit Reward' Option In Manage Pledge Flow #2145
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naveen-C-Ramachandrappa
approved these changes
Sep 5, 2024
scottkicks
requested review from
a team,
jlplks,
ifosli and
stevestreza-ksr
and removed request for
a team and
jlplks
ifosli
approved these changes
Sep 5, 2024
ifosli
pushed a commit
that referenced
this pull request
Sep 5, 2024
… Flow (#2145) * add a test for when the 'update pledge' option is not an option when the feature flag is enabled * scroll to index path should be based on rewards filtered by location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Uses the filtered rewards by location list to scroll to the selected reward via the 'Edit Reward' option in our Manage Pledge flow.
🤔 Why
this is the list the app uses when in our No Shipping At Checkout Flow.
🛠 How
Adds the
filteredByLocationRewardslist to thescrollToBackedRewardIndexPathsignal and chooses the right list to use based on if that list is empty or not.👀 See
✅ Acceptance criteria
No Shipping At Checkoutfeature flag is onNo Shipping At Checkoutfeature flag is off