[MBL-1680] Shipping Info Missing From Rewards Summary #2144
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the shipping total is 0
ifosli
approved these changes
Sep 4, 2024
| if featureNoShippingAtCheckout() == false { | ||
| // MARK: Shipping | ||
| if let shipping = data.shipping { | ||
| if shipping.total > 0 { |
There was a problem hiding this comment.
nit: This is a little nicer to read if you do if let shipping = data.shipping, shipping.total > 0 { instead of nesting two ifs.
ifosli
pushed a commit
that referenced
this pull request
Sep 5, 2024
* only hide shipping from summary table if there is no shipping data or if the shipping total is 0 * simplify conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if the shipping total is 0
📲 What
For some projects (at least one late pledge project on the confirm details screen), shipping information is missing from the pledge summary table. The total is still correct (includes the shipping).
🤔 Why
For projects that have shipping and have been active already, and since the pledge total includes this amount, we need to show shipping info in the summary tables.
🛠 How
When creating the rewards summary table we have a condition that, If the flag is off, we hide shipping info.
We should update this condition to only hide shipping for projects that don’t have shipping data or if shipping is 0 as it will be for new projects that are created during this estimated shipping rollout.
👀 See
✅ Acceptance criteria