[NO TICKET] Shipping Dropdown Loading State #2126
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Makes sure the shimmer view loads while the shipping dropdown fetches it's locations.
🤔 Why
Without this the dropdown appears empty and visually stutters once the locations have loaded.
🛠 How
Update the view model's isLoading property so that it automatically starts loading when the no checkout at shipping feature flag is enabled.
The current behavior will start loading if the passed in reward has shipping enabled.
This only applies to the existing flow where the dropdown is on the AddOns screen.
Not that it's on the Rewards screen the behavior is different in that we aren't passing in a reward.
👀 See
hard to see the before, but with slower internet it's pretty bad.
✅ Acceptance criteria