Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1448] Add query for PPO fetch #2113

Merged
merged 3 commits into from
Aug 7, 2024
Merged

[MBL-1448] Add query for PPO fetch #2113

merged 3 commits into from
Aug 7, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Aug 5, 2024

πŸ“² What

Add query for PPO fetch. This pr does not convert graphQL response data to a custom class that we create, though I'm still not sure what the best approach for the response is.

πŸ‘€ See

Jira

βœ… Acceptance criteria

  • Fetch works and returns useful data. (I tested this by temporarily hooking it up to the "report project" page, since that had a similar graphQL in swiftui fetch I could easily swap out.)

⏰ TODO

  • Check with iOS team if we want to keep this approach

@ifosli ifosli self-assigned this Aug 5, 2024
@ifosli ifosli marked this pull request as ready for review August 6, 2024 16:25
@ifosli ifosli merged commit ecd0639 into main Aug 7, 2024
5 checks passed
@ifosli ifosli deleted the ppoQuery branch August 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants