[MBL-1447] Create fragments for PPO #2111
Merged
+1,228
−1,477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Aug 1, 2024
There was a problem hiding this comment.
Fyi, this giant file is automatically generated (by a script that we run in terminal). I don't typically look through changes here (there's a lot of lines of code) unless something in our build breaks.
Generated by 🚫 Danger |
scottkicks
approved these changes
Aug 5, 2024
| } | ||
| image { | ||
| id | ||
| url(width: 1024) |
There was a problem hiding this comment.
I didn't realize you could add parameters in fragments like this.
There was a problem hiding this comment.
Yeah! I think hardcoded parameters pretty much work the same as the ones we pass in. This one is just copied from our normal project fragment, though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Create fragments for PPO, so that we can fetch exactly the data we need for the cards. These fragments can be updated to include more fields if we discover we need them.
👀 See
Jira
✅ Acceptance criteria