Swift UI styling #2110
Merged
Swift UI styling #2110
+127
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func makeBody(configuration: Configuration) -> some View { | ||
| configuration.label | ||
| .frame(maxWidth: .infinity) | ||
| .font(Font(UIFont.boldSystemFont(ofSize: 16))) |
There was a problem hiding this comment.
Should these be ksr_body or one of the other defined fonts? (Same question for the other button styles in this file)
There was a problem hiding this comment.
I don't think so - I've copied all the details here from our current buttons (except the fact that these buttons can grow to multiple lines), and I don't think this matches any of our current fonts. We should maybe update the font we use on our buttons, but that feels a little out of scope for this. I'll confirm with Alison, though!
There was a problem hiding this comment.
Confirmed with Alison that we're matching old styling with these buttons (and hopefully eventually we'll update all of them to something that matches the rest of the app better!)
scottkicks
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Create and use swiftui button styles to match our UIKit styling for buttons. Note that this is done with
SwiftUI.ButtonStyles, not using view modifiers. This gives us access to theisPressedfield, which looks equivalent to the UIKit highlighted state.I've only copied over the styles that I think we need. If I've missed anything, either for a different kind of button or something from BaseStyles, we can add it when we need it. (Or let me know, and I can add it here.)
Note that tests don't cover the
isPressedstate - I couldn't find a way to do this. If it's possible and anyone knows how to do it, let me know, and I'll add a "highlighted" state snapshot test.👀 See
Jira
Button styles can be seen in the snapshot tests.
✅ Acceptance criteria