MBL-1449: Implement createOrUpdateBackingAddress mutation #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @testable import KsApi | ||
| import XCTest | ||
|
|
||
| final class ConfirmBackingAddressMutationTests: XCTestCase { |
There was a problem hiding this comment.
These tests are a little silly since they're just exercising the MockService 🤷♀️. But at least they provide a little documentation of what the Service call can do.
| @@ -413,6 +413,9 @@ public protocol ServiceType { | |||
|
|
|||
| func exchangeTokenForOAuthToken(params: OAuthTokenExchangeParams) | |||
| -> AnyPublisher<OAuthTokenExchangeResponse, ErrorEnvelope> | |||
|
|
|||
| /// Confirms a backer's address for a given backing. Returns a success boolean. | |||
| func confirmBackingAddress(backingId: String, addressId: String) -> AnyPublisher<Bool, ErrorEnvelope> | |||
There was a problem hiding this comment.
n.B. I'm just taking the ids and inputs and outputting the success boolean; seems much cleaner to me than making extra input/output objects.
amy-at-kickstarter
force-pushed
the
feat/adyer/mbl-1449/createOrUpdateBackingAddress
branch
from
6fb0bc7
to
32147b5
Compare
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
ifosli
approved these changes
May 31, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/mbl-1449/createOrUpdateBackingAddress
branch
from
32147b5
to
aec34af
Compare
amy-at-kickstarter
deleted the
feat/adyer/mbl-1449/createOrUpdateBackingAddress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add the
createOrUpdateBackingAddressto the app.🤔 Why
This mutation is used to confirm a backer's address for a given backing; it will be used in the PPO dashboard.