Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort backed projects by end date #2069

Merged
merged 2 commits into from
May 29, 2024
Merged

Sort backed projects by end date #2069

merged 2 commits into from
May 29, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented May 28, 2024

📲 What

Sort backed projects by project end date instead of backing date by switching what graphQL query we use.

🤔 Why

Sorting by backing date looked to disorganized, especially for superbackers.

👀 See

Jira

Before 🐛 After 🦋
image image

✅ Acceptance criteria

  • Backed projects list looks organized

⏰ TODO

  • File jira ticket for followup work to add headers - see https://kickstarter.atlassian.net/browse/MBL-1521
  • Either fix the bug where late pledge projects don't show up under backed projects (as long as they're not also starred) or get the okay to merge this pr with this bug and reopen the corresponding ticket. - we're merging this and opening a BE bug ticket

@ifosli ifosli self-assigned this May 28, 2024
@ifosli ifosli marked this pull request as ready for review May 28, 2024 17:59
@ifosli ifosli requested review from a team and amy-at-kickstarter and removed request for a team May 28, 2024 17:59
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any double-checking required for late pledges?

@ifosli
Copy link
Contributor Author

ifosli commented May 28, 2024

LGTM. Any double-checking required for late pledges?

Ohh, good call. I checked and that bug where the project doesn't show up is back

@amy-at-kickstarter
Copy link
Contributor

LGTM. Any double-checking required for late pledges?

Ohh, good call. I checked and that bug where the project doesn't show up is back

😭

@ifosli ifosli merged commit ed4f2f5 into main May 29, 2024
5 checks passed
@ifosli ifosli deleted the sortBackedProjectByEndDate branch May 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants