Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1439] Remove 'Block Users' Feature Flag #2059

Merged
merged 2 commits into from
May 15, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented May 14, 2024

📲 What

Removes Block Users Feature Flag.

🤔 Why

It has been on at 100% for some time now. It's time to say goodbye.
Also I want to focus on cleaning our flags up more consistently.

🛠 How

  • Remove flag from RemoteConfigFeature and all subsequent tests and helpers
  • Remove any guards that use this feature flag.

👀 See

No Changes

♿️ Accessibility

No changes

🏎 Performance

Same

✅ Acceptance criteria

  • Blocking users still works as expected. Areas where we can block users:
    • Creator profile icon, Comments, Comment Replies, Messages

⏰ TODO

  • Create an Epic to track cleaning up the other flags that can be removed

@scottkicks scottkicks self-assigned this May 14, 2024
@scottkicks scottkicks marked this pull request as ready for review May 14, 2024 19:01
@scottkicks scottkicks requested review from a team and ifosli and removed request for a team May 14, 2024 19:01
Copy link
Contributor

@ifosli ifosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Once this is in, we should also update the flag in remote config to stop sending it to new builds (and maybe eventually delete it entirely, assuming we're okay with reverting block user functionality for the builds that depended on the flag)

@scottkicks
Copy link
Contributor Author

Nice! Once this is in, we should also update the flag in remote config to stop sending it to new builds (and maybe eventually delete it entirely, assuming we're okay with reverting block user functionality for the builds that depended on the flag)

@ifosli Agreed! I have a condition ready to be published once that says that anyone on the current 5.15.0 version or below will respond as if this flag is set to true/enabled.
Screenshot 2024-05-14 at 1 23 00 PM

Screenshot 2024-05-14 at 1 24 52 PM

@scottkicks scottkicks force-pushed the scott/debt/block-users-flag-cleanup branch from 5e49125 to 6e0a8ca Compare May 15, 2024 20:59
@scottkicks scottkicks merged commit 2d7d832 into main May 15, 2024
5 checks passed
@scottkicks scottkicks deleted the scott/debt/block-users-flag-cleanup branch May 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants