MBL-1372: Don't call createToken after ApplePayContext completes #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -345,21 +345,27 @@ public class PostCampaignCheckoutViewModel: PostCampaignCheckoutViewModelType, | |||
| } | |||
|
|
|||
| let completeCheckoutWithApplePayInput: Signal<GraphAPI.CompleteOnSessionCheckoutInput, Never> = Signal | |||
| .combineLatest(newPaymentIntentForApplePay, checkoutId, self.applePayParamsSignal) | |||
| .combineLatest(newPaymentIntentForApplePay, checkoutId, self.applePayParamsSignal.mapConst(true)) | |||
There was a problem hiding this comment.
I'm leaving this plumbing here, in case we refactor the mutation to accept the other ApplePay parameters - but mapping it to true just so it's a little more clear it's unused.
There was a problem hiding this comment.
I'm pretty sure we'll never send them (stripe has basic apple pay info that the backend can access) but I'm okay with this approach for now!
ifosli
approved these changes
Apr 17, 2024
| @@ -345,21 +345,27 @@ public class PostCampaignCheckoutViewModel: PostCampaignCheckoutViewModelType, | |||
| } | |||
|
|
|||
| let completeCheckoutWithApplePayInput: Signal<GraphAPI.CompleteOnSessionCheckoutInput, Never> = Signal | |||
| .combineLatest(newPaymentIntentForApplePay, checkoutId, self.applePayParamsSignal) | |||
| .combineLatest(newPaymentIntentForApplePay, checkoutId, self.applePayParamsSignal.mapConst(true)) | |||
There was a problem hiding this comment.
I'm pretty sure we'll never send them (stripe has basic apple pay info that the backend can access) but I'm okay with this approach for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Do not create a Stripe token after
ApplePayContextcreates a Stripe PaymentMethod.🤔 Why
In production, this causes Stripe to return an error in the
createTokenendpoint, which breaks our ApplePay flow. Instead, we will ignore thetokenfield andapplePayParamsfield in our mutation, treating an ApplePay transaction like a regular credit card transaction.