MBL-1344: Fix sort for backer dashboard by upgrading V1 query to GraphQL #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Query and FetchMySavedProjectsQuery
| @@ -1,8 +1,21 @@ | |||
| import Foundation | |||
|
|
|||
| public enum ProfileProjectsType: Decodable { | |||
There was a problem hiding this comment.
Moved this here so it could be part of the envelope.
| return SignalProducer(value: envelope) | ||
| } | ||
|
|
||
| static func fetchProjectsEnvelope(from data: GraphAPI.FetchMySavedProjectsQuery.Data) |
There was a problem hiding this comment.
Basically the same as above but shaped slightly differently for the different response.
| @@ -0,0 +1,17 @@ | |||
| query FetchMyBackedProjects($first: Int = null, $after: String = null, $withStoredCards: Boolean = false) { | |||
| me { | |||
| backingsCount | |||
There was a problem hiding this comment.
n.B. that this one uses backingsCount on me whereas the other query uses totalCount on pageInfo. totalCount for whatever reason is deprecated here.
amy-at-kickstarter
changed the title
Generated by 🚫 Danger |
ifosli
approved these changes
Apr 11, 2024
| /* | ||
| This is a very large response object, so load it from a file instead of putting it inline here. | ||
| These are very large response object, so load it from a file instead of putting it inline here. |
There was a problem hiding this comment.
nit: object should be objects
There was a problem hiding this comment.
Ha, will fix
amy-at-kickstarter
deleted the
feat/adyer/MBL-1344/sort-backed-projects-better
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Upgrade the V1 API query on our backer dashboard page to GraphQL to fix its sort. This uses a similar GraphQL query to what we use on the web - querying the
meobject to get backed and saved projects.🤔 Why
Late pledges were being shown based on the project end date, instead of by what was most recently backed. This special sort is only available on
me { backedProjects }.👀 See
Before:
After:
Compare with what I see on web:
On production, I see no difference between before-and-after; I think the effect is much more dramatic on staging because of our dubious data there.