[MBL-1339] Include multiple copies of add-ons if selected #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
requested review from
a team and
scottkicks
and removed request for
a team
scottkicks
approved these changes
Apr 4, 2024
| return [] | ||
| } | ||
| return [String](repeating: reward.graphID, count: count) | ||
| } |
There was a problem hiding this comment.
might be a good idea to add a test for this
There was a problem hiding this comment.
Discussed offline - yeah, I'd be nice, but our test suite isn't designed to test that network calls are constructed correctly. So I'm going to just leave this for now.
ifosli
added a commit
that referenced
this pull request
Apr 4, 2024
scottkicks
added a commit
that referenced
this pull request
Apr 8, 2024
* Include multiple copies of add-ons if selected (#2027) * Update marketing version to 5.14.0 --------- Co-authored-by: Scott Clampet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Send all copies of each reward to the backend. Note that this doesn't fix the bonus support being weird, but that matches a web bug that backend/web people are already working on.
👀 See
Jira
✅ Acceptance criteria