-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate To Thank You Page On Successful Late Pledge #2008
Conversation
bc10ded
to
f6f5f5f
Compare
return (initialData.project, reward, nil, initialData.total) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't look like we needed to pass any CheckoutData in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Do regular pledges require it, or can CheckoutData
be cleaned up from the ThanksPageData
type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I have a note to look at that. I couldn't see find what it was needed for honestly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one suggestion if it's possible.
return (initialData.project, reward, nil, initialData.total) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Do regular pledges require it, or can CheckoutData
be cleaned up from the ThanksPageData
type?
📲 What
Navigates To Thank You Page On Successful Late Pledge
🤔 Why
So we can formally thank users for their pledge, show them verification, and suggest other projects to them
🛠 How
Using data we already have in the PostCampaignCheckoutViewModel, gather the data needed for the Thanks Page.
👀 See
I can't remove backings rn and only have 2 accounts that I used to test already so I can't screen record this.
✅ Acceptance criteria