MBL-1177: Add CompleteOnSessionCheckoutMutation to GraphAPI #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1177/CreateBackingOnCheckoutMutation
branch
from
d342558
to
ece7313
Compare
amy-at-kickstarter
requested review from
a team and
scottkicks
and removed request for
a team
amy-at-kickstarter
changed the title
|
|
||
| extension GraphAPI.CompleteOnSessionCheckoutMutation.Data: Decodable { | ||
| public init(from _: Decoder) throws { | ||
| fatalError("The test code should not actually be decoding this object.") |
There was a problem hiding this comment.
This is required for us to use performWithResult. I'm fairly sure the Decodable requirement is for Apollo, not for the MockGraphQLClient, which doesn't actually do any decoding.
| @@ -77,6 +77,9 @@ public protocol ServiceType { | |||
| func createBacking(input: CreateBackingInput) -> | |||
| SignalProducer<CreateBackingEnvelope, ErrorEnvelope> | |||
|
|
|||
| func completeOnSessionCheckout(input: GraphAPI.CompleteOnSessionCheckoutInput) -> | |||
| SignalProducer<GraphAPI.CompleteOnSessionCheckoutMutation.Data, ErrorEnvelope> | |||
There was a problem hiding this comment.
I'd like to move away from wrapper objects unless we really need them - implementing this as its raw GraphQL types for now; if we need to write a wrapper later, I'm OK doing that just-in-time.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1177/CreateBackingOnCheckoutMutation
branch
from
ece7313
to
b09f77f
Compare
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1177/CreateBackingOnCheckoutMutation
branch
from
b09f77f
to
567dec9
Compare
scottkicks
approved these changes
Mar 18, 2024
amy-at-kickstarter
deleted the
feat/adyer/MBL-1177/CreateBackingOnCheckoutMutation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add CompleteOnSessionCheckoutMutation to GraphAPI.
🤔 Why
This is a new mutation for post-campaign pledging. I modeled it after the mutation it will replace,
createBacking, having it return aCheckoutFragment.👀 See
Trello, screenshots, external resources?