-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub controller for logging in with OAuth #1931
Stub controller for logging in with OAuth #1931
Conversation
06ce422
to
856d19c
Compare
@@ -3067,7 +3068,7 @@ | |||
E1BB25632B1E81AA000BD2D6 /* Publisher+Service.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Publisher+Service.swift"; sourceTree = "<group>"; }; | |||
E1EA34EE2AE1B28400942A04 /* Signal+Combine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Signal+Combine.swift"; sourceTree = "<group>"; }; | |||
E1EEED282B684AA7009976D9 /* PKCE.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PKCE.swift; sourceTree = "<group>"; }; | |||
E1EEED2A2B686829009976D9 /* PKCETest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = PKCETest.swift; path = KsApi/PKCETest.swift; sourceTree = "<group>"; }; | |||
E1EEED2A2B686829009976D9 /* PKCETest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PKCETest.swift; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just kind of floating at the top of the project navigator; small change to fix it.
|
||
extension LoginToutViewController: ASWebAuthenticationPresentationContextProviding { | ||
public func presentationAnchor(for _: ASWebAuthenticationSession) -> ASPresentationAnchor { | ||
return self.view.window! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to unwrap this. Though, I'm don't think it's likely that window will be nil at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. Agreed, but perhaps better safe than sorry in this case.
07b6c38
to
dc9db9b
Compare
📲 What
This is the initial/stubbed version of the login controller, just to allow us to test the entire flow. Note that the login page (and the redirect) aren't pushed on the web yet.
I've marked additional obvious work with
//TODOs
, plus, we'll need to re-jigger the sign-up flow as well. But this is a good start!🤔 Why
This is part of the larger project to move our app login to OAuth.
👀 See
Logging.in.mp4
📓 Please note
This needs to merge after the feature flag PR, #1928. You can ignore that commit in here.