Update build schema to force you to select correct target when building tests #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-coreaudiotypes-linker-error
branch
from
d27d2a8
to
ce200b9
Compare
amy-at-kickstarter
changed the title
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-coreaudiotypes-linker-error
branch
from
ce200b9
to
8fd48bc
Compare
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-coreaudiotypes-linker-error
branch
from
8fd48bc
to
a0ac3ef
Compare
…ng tests I found that this change improved the number of linker errors I got when running individual tests via Xcode.
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-coreaudiotypes-linker-error
branch
from
a0ac3ef
to
20a7964
Compare
amy-at-kickstarter
deleted the
feat/adyer/fix-coreaudiotypes-linker-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Force you to select the correct build schema when running tests via Xcode.
🤔 Why
Say you have an arbitrary target selected, and you try and run some tests by hitting the play button. In this example, I'm trying to run a test in
Library-iOS-Tests, and I have theKickstarter-iOStarget selected, because I was running the app.You might be treated to this linker error. However, look closely - why is it trying and failing to build
KsApiTests?This is odd - while
Library-iOSdepends onKsApi,Library-iOS-Testsdoes NOT depend onKsApiTests.Looking into the dependency graphs, and it looks like the app is trying to build
Kickstarter-iOS, and then as part of that, it includedKsApiTests. That is also odd. First, why is it buildingKickstarter-iOSinstead of justLibrary-iOSandLibrary-iOS-Tests? And for that matter, why wouldKickstarter-iOS(the app) depend onKsApiTests(a test bundle)?It turns out the answer was in the schema.
Kickstarter-iOSwas set up so that it was associated with all of our tests, and it would try to run them (all!) if it was selected as the schema when you run any tests. As far as I can tell, this led to general Xcode and linker strangeness, until you either swapped targets or ran a full project clean.The solution was to uncheck all those test boxes. Now, when you try to run a test in the same scenario, you get this handy pop-up that forces you to swap to the correct test target: