Move CombineTestObserver files to the test target #1923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Move combineTestObserver to all test targets and its corresponding test to the
KsApiTests
target. Otherwise, the app crashes on launch.I think there's probably a better way to ensure
combineTestObserver
is accessible to all test targets without being accessible outside of tests, but I think that would involve creating a separate target just for it, and I'm not sure if that's worth it.✅ Acceptance criteria