-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-943] Add Additional Header Support to HTML Parser #1844
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1844 +/- ##
==========================================
+ Coverage 84.52% 84.53% +0.01%
==========================================
Files 1272 1272
Lines 115287 115364 +77
Branches 30693 30710 +17
==========================================
+ Hits 97451 97528 +77
Misses 16767 16767
Partials 1069 1069
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than I see that the headers, World's First Automated Wakesurf Rope System
and 100% Automatic to the Surfer and Back to Start
are indented unlike the other headers below them.
Could that be an issue with our parser or is that just how the html is initially for this project?
Thanks for linking the android PR. Its good to see that we're maintaining feature parody on with this.
Not sure what - if any - changes are required here. |
@msadoon meant that to be an approval, not a comment. my bad 😅 |
📲 What
There's been a change on the web to support a new parser called
CKEditor
and it supports additional header tags. Previously we supported onlyh1
. Now we supporth1
,h2
,h3
,h4
,h5
,h6
.🤔 Why
As stated above, we would eventually need to add new elements/HTML tags supported by more modern project creation tools.
🛠 How
Pretty straightforward, taking a look at the Android pull request that does the exact same thing. Used the font sizes for reference so they should be the same size on both platforms.
Might be nice to screenshot test all the supported HTML components one day...thinking when we remove the parser and get good support for
story
properties on theProjectFragment
we can look into this.👀 See
✅ Acceptance criteria
h1
headers are larger size after the change. Before this change they were size20
, now they are28
. Ie. WakeFX Rope-Pal - Automated Waksurf Rope System on staging. (screens above).h3
andh4
would not show. HTML snippet from sample project:<h3 id=\"h:Header\" class=\"page-anchor\">Header</h3><h4 id=\"h:Subheader\" class=\"page-anchor\">Subheader</h4>
, but now they do. (screens above)⏰ TODO