-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No Ticket] Full MockOptimizely Removal PR Fixes/Cleanup #1825
Conversation
…oject_NotShowingCampaign_Success
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
=======================================
Coverage 84.35% 84.36%
=======================================
Files 1276 1276
Lines 115449 115436 -13
Branches 30743 30738 -5
=======================================
- Hits 97392 97383 -9
+ Misses 16990 16986 -4
Partials 1067 1067
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close to perfect, haha, just remember if we remove a test in a view controller to remove the corresponding screenshots.
Kickstarter-iOS/Features/Comments/Controllers/CommentsViewControllerTests.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Assuming tests pass] Update the milestone to 5.9.0 - but don't merge this pr yet. Let's merge the marketing version update for 5.8.0 first, close out milestone 5.8.0 (no action required), update the release branch (main
--> release-5.8.0
PR), then merge this in.
📲 What
Regarding my Full MockOptimizely Removal PR
There are some further changes and cleanup that can be done.
🤔 Why
Its important to be thorough in code cleanup, making sure to really understand why certain changes are being made and how best to address removing and/or cleaning up so that we can guarantee that our app is better for it.
🛠 How
.ksr_remoteConfigClientConfigured
&.ksr_remoteConfigClientConfigurationFailed
notificationspaymentSheetEnabled
&campaignTabEnabled
that were previously updated✅ Acceptance criteria
⏰ TODO